-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test – Point Gutenberg to a commit to verify XCFramework setup #20741
Closed
mokagio
wants to merge
22
commits into
mokagio/gutenberg-xcframework-setup
from
test/gutenberg-xcframework-setup
Closed
Test – Point Gutenberg to a commit to verify XCFramework setup #20741
mokagio
wants to merge
22
commits into
mokagio/gutenberg-xcframework-setup
from
test/gutenberg-xcframework-setup
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
2 tasks
mokagio
force-pushed
the
mokagio/gutenberg-xcframework-setup
branch
from
May 25, 2023 12:12
25884d2
to
6f74940
Compare
mokagio
force-pushed
the
test/gutenberg-xcframework-setup
branch
from
May 25, 2023 12:17
3e0bea4
to
6ecc911
Compare
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
mokagio
force-pushed
the
test/gutenberg-xcframework-setup
branch
from
May 30, 2023 04:24
f312f9e
to
2af0f9d
Compare
No other than reason than me looking at the CocoaPods setup and realizing we were a few versions behind.
Despite it working during the prototype stage, I wasn't able to get the XCFrameworks out of the ZIP archive, but it works fine with the tar.gz. I suspect this has to do with the folder(s) generated when decompressing.
These are unnecessary at the moment but will be when we move to Gutenberg via XCFramework
mokagio
force-pushed
the
mokagio/gutenberg-xcframework-setup
branch
from
May 31, 2023 12:11
6f74940
to
e9dca95
Compare
Hoping for better test failure annotation.
This was done to address the following CI failure when building with the Gutenberg XCFramework: ``` ▸ Linking WordPress⚠️ ld: Could not find or use auto-linked library 'swiftCompatibility56' ❌ ld: symbol(s) not found for architecture x86_64 ``` https://buildkite.com/automattic/wordpress-ios/builds/14356#01885545-c05a-43a8-b475-d0d683857672 The CocoaPods upgrade was necessary to work around an incompatibility issue with the earlier CP version and Xcode 14.3 when archiving.
mokagio
force-pushed
the
test/gutenberg-xcframework-setup
branch
from
May 31, 2023 12:29
4a83184
to
7c440b4
Compare
mokagio
force-pushed
the
test/gutenberg-xcframework-setup
branch
from
June 1, 2023 04:51
60890de
to
18d815f
Compare
mokagio
force-pushed
the
test/gutenberg-xcframework-setup
branch
from
June 1, 2023 05:38
0ad21b7
to
d782a0c
Compare
mokagio
force-pushed
the
test/gutenberg-xcframework-setup
branch
from
June 1, 2023 13:15
df6ee0f
to
1a26964
Compare
mokagio
force-pushed
the
mokagio/gutenberg-xcframework-setup
branch
from
June 2, 2023 03:17
0ff26e5
to
5b7a7b7
Compare
This has gotten noisy. Closing in favor of #20792 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #20717 to verify it work in CI.
Update: This has gotten noisy. Closing in favor of #20792