Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test – Point Gutenberg to a commit to verify XCFramework setup #20741

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented May 25, 2023

Built on top of #20717 to verify it work in CI.


Update: This has gotten noisy. Closing in favor of #20792

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 25, 2023

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@mokagio mokagio force-pushed the mokagio/gutenberg-xcframework-setup branch from 25884d2 to 6f74940 Compare May 25, 2023 12:12
@mokagio mokagio force-pushed the test/gutenberg-xcframework-setup branch from 3e0bea4 to 6ecc911 Compare May 25, 2023 12:17
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 26, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20741-1a26964
Version22.5
Bundle IDcom.jetpack.alpha
Commit1a26964
App Center Buildjetpack-installable-builds #4861
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 26, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20741-1a26964
Version22.5
Bundle IDorg.wordpress.alpha
Commit1a26964
App Center BuildWPiOS - One-Offs #5831
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio mokagio force-pushed the test/gutenberg-xcframework-setup branch from f312f9e to 2af0f9d Compare May 30, 2023 04:24
@mokagio mokagio requested a review from a team as a code owner May 30, 2023 04:24
mokagio added 10 commits May 31, 2023 21:22
No other than reason than me looking at the CocoaPods setup and
realizing we were a few versions behind.
Despite it working during the prototype stage, I wasn't able to get the
XCFrameworks out of the ZIP archive, but it works fine with the tar.gz.

I suspect this has to do with the folder(s) generated when
decompressing.
These are unnecessary at the moment but will be when we move to
Gutenberg via XCFramework
@mokagio mokagio force-pushed the mokagio/gutenberg-xcframework-setup branch from 6f74940 to e9dca95 Compare May 31, 2023 12:11
mokagio added 2 commits May 31, 2023 22:21
Hoping for better test failure annotation.
This was done to address the following CI failure when building with the
Gutenberg XCFramework:

```
▸ Linking WordPress
⚠️  ld: Could not find or use auto-linked library 'swiftCompatibility56'

❌  ld: symbol(s) not found for architecture x86_64
```

https://buildkite.com/automattic/wordpress-ios/builds/14356#01885545-c05a-43a8-b475-d0d683857672

The CocoaPods upgrade was necessary to work around an incompatibility
issue with the earlier CP version and Xcode 14.3 when archiving.
@mokagio mokagio force-pushed the test/gutenberg-xcframework-setup branch from 4a83184 to 7c440b4 Compare May 31, 2023 12:29
@mokagio mokagio force-pushed the test/gutenberg-xcframework-setup branch from 60890de to 18d815f Compare June 1, 2023 04:51
@mokagio mokagio force-pushed the test/gutenberg-xcframework-setup branch from 0ad21b7 to d782a0c Compare June 1, 2023 05:38
@mokagio mokagio force-pushed the test/gutenberg-xcframework-setup branch from df6ee0f to 1a26964 Compare June 1, 2023 13:15
@mokagio mokagio force-pushed the mokagio/gutenberg-xcframework-setup branch from 0ff26e5 to 5b7a7b7 Compare June 2, 2023 03:17
@mokagio
Copy link
Contributor Author

mokagio commented Jun 2, 2023

This has gotten noisy. Closing in favor of #20792

@mokagio mokagio closed this Jun 2, 2023
@mokagio mokagio deleted the test/gutenberg-xcframework-setup branch June 2, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants