Add additional flag to opt out of sync module installation #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description =========== This patch adds a API addition which is fully backwards compatible both in API and behavior. I added a new `installUnityEditor` overload which adds a new property `syncChildComponents`. I used the naming scheme from uvm. So it's component instead of modules. The current default behavior is to install all sub modules of a given module. e.g. Android will also install android NDK, SDK etc. We want to opt out of this. For this library I would like to keep the old behavior and fix it on the calling side. Changes ======= * ![ADD] boolean flag to opt out of sync module installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch adds a API addition which is fully backwards compatible both in API and behavior. I added a new
installUnityEditoroverload which adds a new propertysyncChildComponents. I used the naming scheme from uvm. So it's component instead of modules. The current default behavior is to install all sub modules of a given module. e.g. Android will also install android NDK, SDK etc.We want to opt out of this. For this library I would like to keep the old behavior and fix it on the calling side.
Changes