-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor icons: harmonize contextually, use filled status icons #4584
Conversation
for more information, see https://pre-commit.ci
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
59fc1e9
to
f76b94b
Compare
f76b94b
to
e4bbceb
Compare
This is another all or nothing discussion:
To me, there is no need to use ALL outlined icons whenever possible. But this time I'll leave the decision to someone else 😃 Personally, I don't like the octagon icons. |
@pat-s what do you think about |
Fine with me. Overall I am wondering if there should be different icons for error and warning. |
If we stick with different colors, I don't think it's necessary. Do you have an idea for different icons? |
Maybe |
Yeah it doesn't fit so well. I think my thought was wrong. So now, h-8 w-8 paired with 1.3rem. Is that good for everyone? |
While it might make sense to use w-8 h-8 instead of -9 how is this related to the default size of the icons? Changing them to 1.2rem will not make them fit with the default line height of 24px. Would just like to understand how to use the 8-point grid correctly. |
Can we outsource this into a discussion/chat? |
Co-authored-by: Robert Kaussow <[email protected]>
@pat-s I did the remaining cleanups:
I hope it was ok to push to your branch. If not please feel free to revert. Please re-check, if you dont have anything to add we are good to go now. |
Thanks cleaning up and all the feedback! Much appreciated. |
Now we have merge conflicts again 😐 |
Tearing down https://woodpecker-ci-woodpecker-pr-4584.surge.sh |
Finally 😁 thanks again! |
Follow-up to #4414 which started to use the outline icon-set for the pipeline status icons.
circleFilled
iconsoutline
iconsalert/error/warning
icons to a single icons and distinguish by color