Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define and implement secret querier via func interface to let pipeline compiler secrets #4380

Closed
wants to merge 7 commits into from

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 14, 2024

Address #4378

  • this only sends secrets used to the agent
  • allow for future improvement to inject a secret-querier that query an secret backend directly

@6543 6543 added refactor delete or replace old code engine change how the pipeline engine works labels Nov 14, 2024
@6543 6543 changed the title Use secretsQuerier func to let pipeline compiler interface secrets Define and implement secret querier via func interface to let pipeline compiler secrets Nov 14, 2024
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Nov 14, 2024

Deployment of preview was torn down

cli/exec/exec.go Show resolved Hide resolved
@6543 6543 added security enhancement improve existing features labels Nov 15, 2024
cli/exec/exec.go Show resolved Hide resolved
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 67.27273% with 18 lines in your changes missing coverage. Please review.

Project coverage is 27.47%. Comparing base (5699d22) to head (ed90798).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
cli/exec/exec.go 0.00% 12 Missing ⚠️
pipeline/frontend/yaml/compiler/compiler.go 40.00% 2 Missing and 1 partial ⚠️
server/pipeline/stepbuilder/stepBuilder.go 90.00% 1 Missing and 1 partial ⚠️
agent/logger.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4380      +/-   ##
==========================================
+ Coverage   27.37%   27.47%   +0.09%     
==========================================
  Files         380      380              
  Lines       27794    27800       +6     
==========================================
+ Hits         7608     7637      +29     
+ Misses      19501    19478      -23     
  Partials      685      685              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@6543 6543 requested a review from a team November 15, 2024 04:16
@6543 6543 marked this pull request as draft November 15, 2024 18:06
@6543
Copy link
Member Author

6543 commented Nov 15, 2024

-> this destryes the usage of secrets to only maks the log of certain output ...

I'll worke on an other method to not have to send all secrets to the agent

@6543
Copy link
Member Author

6543 commented Nov 19, 2024

-> #4384

@6543 6543 closed this Nov 19, 2024
@6543 6543 deleted the secretQuerier branch November 19, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine change how the pipeline engine works enhancement improve existing features refactor delete or replace old code security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants