Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Data: Migrate storage usage for ShippingMethodStore #14568

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Dec 2, 2024

Part of #14122

Description

This PR adds a small change to migrate the deprecated usage of writerDerivedStorage to use the new method performAndSave in ShippingMethodStore to ensure the write operations are handled by the writer operation queue.

Steps to reproduce

  • Log in to a test store.
  • Navigate to the Orders tab and select + to add a new order.
  • Select one or more products.
  • Select Add Shipping > Method.
  • Confirm that the correct shipping methods are displayed.

Testing information

Tested with simulator iPhone 16 Pro iOS 18.1 and confirmed that shipping methods can be synced and displayed correctly after the changes.

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@itsmeichigo itsmeichigo added type: task An internally driven task. feature: order creation All tasks related to creating an order labels Dec 2, 2024
@itsmeichigo itsmeichigo added this to the 21.3 milestone Dec 2, 2024
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14568-c6259ae
Version21.2
Bundle IDcom.automattic.alpha.woocommerce
Commitc6259ae
App Center BuildWooCommerce - Prototype Builds #11886
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well. Unrelated to your changes I found a bug/enhancement related to free shipping, logged it here: #14584

UI tests seems to have failed more than once, I've ran them again to see if it's flakiness or something else 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: order creation All tasks related to creating an order type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants