Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shipping labels] Add UI for selected package and shipment weight #14565

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

rachelmcr
Copy link
Contributor

@rachelmcr rachelmcr commented Nov 29, 2024

Part of: #14522

Description

This adds the UI for displaying the selected package and total shipment weight in the Woo Shipping label creation flow.

How

  • Moves the reusable PackageOptionView to a separate file for visibility.
    • Updates this view to make the selector optional, so the view can be used for the selected package.
    • Fixes a couple small text style issues in the view.
  • Adds SelectedPackageView to display the package section with the selected package and total shipment weight.
    • This view has an edit button, for editing the selected package; the action will be added in a future PR.
    • For now, this view isn't yet used on the main screen for the Woo Shipping flow; it will be added (with real data) in a future PR.

Testing information

Prerequisite: The Woo Shipping extension is active on your store and you have at least one order eligible for a shipping label (with processing status and at least one physical product).

  1. Enable the revampedShippingLabelCreation feature flag.
  2. Build and run the app.
  3. Go to the Orders tab.
  4. Select an order eligible for a shipping label.
  5. Tap "Create Shipping Label."
  6. Tap "Select a package."
  7. Confirm the rows in the carriers and saved tab look the same as before.

Screenshots

SwiftUI preview of the new view:


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@rachelmcr rachelmcr added the feature: shipping labels Related to creating, ordering, or printing shipping labels. label Nov 29, 2024
@rachelmcr rachelmcr added this to the 21.3 milestone Nov 29, 2024
@rachelmcr rachelmcr force-pushed the issue/14522-selected-package-ui branch from b32a287 to 4bdd12e Compare November 29, 2024 18:26
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14565-4bdd12e
Version21.2
Bundle IDcom.automattic.alpha.woocommerce
Commit4bdd12e
App Center BuildWooCommerce - Prototype Builds #11877
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@rachelmcr rachelmcr merged commit c99db1c into trunk Nov 29, 2024
15 checks passed
@rachelmcr rachelmcr deleted the issue/14522-selected-package-ui branch November 29, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants