Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Product] Update product tag store to migrate Core Data usage and fix a few issues #14511

Merged
merged 24 commits into from
Nov 29, 2024
Merged

[Product] Update product tag store to migrate Core Data usage and fix a few issues #14511

merged 24 commits into from
Nov 29, 2024

Commits on Nov 26, 2024

  1. Replace deprecated use of writerDerivedStorage

    @itsmeichigo
    itsmeichigo committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    de2310b View commit details
    Browse the repository at this point in the history

  2. Remove unused tags as part of the upsertion

    @itsmeichigo
    itsmeichigo committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    149e08f View commit details
    Browse the repository at this point in the history

  3. Handle deleteStoredProductTags in background

    @itsmeichigo
    itsmeichigo committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    c646ba1 View commit details
    Browse the repository at this point in the history

  4. Remove unused method deleteUnusedStoredProductTags and move the logic… 

    … to be as part of upsertion
    @itsmeichigo
    itsmeichigo committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    7450cef View commit details
    Browse the repository at this point in the history

  5. Add new field count for ProductTag

    @itsmeichigo
    itsmeichigo committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    5c6a7f4 View commit details
    Browse the repository at this point in the history

  6. Only upsert product tags with associated products

    @itsmeichigo
    itsmeichigo committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    9ee30af View commit details
    Browse the repository at this point in the history

  7. Fix test build failure

    @itsmeichigo
    itsmeichigo committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    5f103af View commit details
    Browse the repository at this point in the history

  8. Add test for addProductTags to check when tag list is empty

    @itsmeichigo
    itsmeichigo committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    d1c2ba4 View commit details
    Browse the repository at this point in the history

  9. Set default value for count to avoid unnecessary changes

    @itsmeichigo
    itsmeichigo committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    c1ddb99 View commit details
    Browse the repository at this point in the history

  10. Fix test failure for ProductTagStore

    @itsmeichigo
    itsmeichigo committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    56b23b3 View commit details
    Browse the repository at this point in the history

  11. Add comment explaining the count property for ProductTag

    @itsmeichigo
    itsmeichigo committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    ad897f4 View commit details
    Browse the repository at this point in the history

  12. Update unit tests for ProductTagStore

    @itsmeichigo
    itsmeichigo committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    9a4c9ad View commit details
    Browse the repository at this point in the history

  13. Remove count property from tag initializers

    @itsmeichigo
    itsmeichigo committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    7c6fd0a View commit details
    Browse the repository at this point in the history

  14. Merge branch 'trunk' into task/14091-product-tag-store-update

    @itsmeichigo
    itsmeichigo committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    ec63dfe View commit details
    Browse the repository at this point in the history

  15. Update release notes

    @itsmeichigo
    itsmeichigo committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    2afea69 View commit details
    Browse the repository at this point in the history

  16. Fetch all items in one go to avoid multiple fetches

    @itsmeichigo
    itsmeichigo committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    c6b7feb View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. Merge branch 'trunk' into task/14091-product-tag-store-update

    @itsmeichigo
    itsmeichigo committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    501eb95 View commit details
    Browse the repository at this point in the history

  2. Revert change to synchronizeProductTags method

    @itsmeichigo
    itsmeichigo committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    e5f3ab2 View commit details
    Browse the repository at this point in the history

  3. Revert addition of count property

    @itsmeichigo
    itsmeichigo committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    c1010cc View commit details
    Browse the repository at this point in the history

  4. Revert changes to unit tests

    @itsmeichigo
    itsmeichigo committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    2b06eb8 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2024

  1. Update comment on deleteStoredProductTags

    @itsmeichigo
    itsmeichigo committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    31008d3 View commit details
    Browse the repository at this point in the history

  2. Display cached tags immediately upon loading tags

    @itsmeichigo
    itsmeichigo committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    cd4946a View commit details
    Browse the repository at this point in the history

  3. Only trigger tag creation if there are any tags confirmed

    @itsmeichigo
    itsmeichigo committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    c77d166 View commit details
    Browse the repository at this point in the history

  4. Update release notes

    @itsmeichigo
    itsmeichigo committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    8cd948a View commit details
    Browse the repository at this point in the history