-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hack Week] ApiFaker: Home screen and integration with the app #13064
base: task/api-faker-1
Are you sure you want to change the base?
Conversation
Generated by 🚫 Danger |
a78cf8f
to
b78c986
Compare
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
94d250f
to
360e2ec
Compare
Otherwise we won't get the preference value
7dd5408
to
a25dfe5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @hichamboushaba. Everything works as expected. Just left a minor point for discussion but nothing blocking :)
Description
As part of my Hack Week, I'm bringing back the ApiFaker project paqN3M-SI-p2, and I'm splitting the feature into multiple PRs.
This PR adds the home screen of the ApiFaker module, and integrates with the app (in the developer options screen), the next PR will add the logic to add/edit/delete endpoints.
Steps to reproduce
Testing information
The tests that have been performed
^
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: