Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hack Week] ApiFaker: Home screen and integration with the app #13064

Open
wants to merge 15 commits into
base: task/api-faker-1
Choose a base branch
from

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Dec 4, 2024

Description

As part of my Hack Week, I'm bringing back the ApiFaker project paqN3M-SI-p2, and I'm splitting the feature into multiple PRs.

This PR adds the home screen of the ApiFaker module, and integrates with the app (in the developer options screen), the next PR will add the logic to add/edit/delete endpoints.

Steps to reproduce

  1. Use a debug build.
  2. Open the settings screen.
  3. Tap on Developer Options.
  4. Tap on ApiFaker.

Testing information

  • Confirm that the option is visible in Developer Options.
  • Confirm that the option opens the ApiFaker home screen.
  • Confirm that navigation works as expected.

The tests that have been performed

^

Images/gif



  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@hichamboushaba hichamboushaba added the type: task An internally driven task. label Dec 4, 2024
@hichamboushaba hichamboushaba changed the base branch from trunk to task/api-faker-1 December 4, 2024 14:03
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 4, 2024

4 Errors
🚫 Please add tests for class ApiFakerConfig (or add unit-tests-exemption label to ignore this).
🚫 Please add tests for class Screen (or add unit-tests-exemption label to ignore this).
🚫 Please add tests for class HomeViewModel (or add unit-tests-exemption label to ignore this).
🚫 This PR is tagged with status: do not merge label(s).
1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 4, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit9375f2d
Direct Downloadwoocommerce-wear-prototype-build-pr13064-9375f2d.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 4, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit9375f2d
Direct Downloadwoocommerce-prototype-build-pr13064-9375f2d.apk

@hichamboushaba hichamboushaba changed the title [API Faker] Main UI and logic [Hack Week] API Faker: Home screen and integration with the app Dec 4, 2024
@hichamboushaba hichamboushaba force-pushed the task/api-faker-2 branch 5 times, most recently from 94d250f to 360e2ec Compare December 4, 2024 17:39
@hichamboushaba hichamboushaba added this to the 21.3 milestone Dec 5, 2024
@hichamboushaba hichamboushaba added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Dec 5, 2024
@hichamboushaba hichamboushaba changed the title [Hack Week] API Faker: Home screen and integration with the app [Hack Week] ApiFaker: Home screen and integration with the app Dec 5, 2024
Zulu-1540

This comment was marked as spam.

@hichamboushaba hichamboushaba marked this pull request as ready for review December 5, 2024 11:14
@JorgeMucientes JorgeMucientes self-assigned this Dec 9, 2024
Copy link
Contributor

@JorgeMucientes JorgeMucientes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @hichamboushaba. Everything works as expected. Just left a minor point for discussion but nothing blocking :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: do not merge Dependent on another PR, ready for review but not ready for merge. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants