Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#345 - Refactor: Clean folder structure #347

Merged
merged 13 commits into from
Dec 10, 2024
Merged

#345 - Refactor: Clean folder structure #347

merged 13 commits into from
Dec 10, 2024

Conversation

mukireus
Copy link
Contributor

@mukireus mukireus commented Dec 9, 2024

Description

  • Example projects have been moved to the examples folder.
  • The used packages have been moved to the packages folder.

See

Before After
Screenshot Before Screenshot After

Note

This change only includes packages and examples. In a new PR, we should also move the wolt_modal_sheet package into the packages folder.

Related Issues

#345

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

mukireus added 12 commits December 1, 2024 15:55
@mukireus
refactor: move coffee_maker example project from root to examples folder
0c59984
@mukireus
refactor: move coffee_maker_navigator_2 example project from root to …
c182bc0 
…examples folder
@mukireus
refactor: move demo_ui_components example project from root to exampl…
9937b28 
…es folder
@mukireus
refactor: move playground example project from root to examples folder
a95161d
@mukireus
refactor: move playground_navigator2 example project from root to exa…
a6c0c76 
…mples folder
@mukireus
refactor: move widgetbook example project from coffe_maker_navigator2…
28ca416 
… to examples folder
@mukireus
chore: update dependency paths in example projects for consistency
48a3234
@mukireus
refactor: move wolt_di package from root to packages folder
edfeacf
@mukireus
refactor: move wolt_state_management package from root to packages fo…
62416ba 
…lder
@mukireus
chore: update dependency paths in packages for consistency
f800245
@mukireus
Revert "refactor: move widgetbook example project from coffe_maker_na…
96dab7e 
…vigator2 to examples folder"

This reverts commit 28ca416.
@mukireus
chore: update paths on yaml files
96ecf7e
TahaTesser
TahaTesser requested changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@TahaTesser TahaTesser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. However, in order to land this change we should also update examples references in the root README file so the links still work after the refactor.

@mukireus
Copy link
Contributor Author

mukireus commented Dec 9, 2024

@TahaTesser Thank you for your review. I have updated the README file.

@mukireus
Copy link
Contributor Author

mukireus commented Dec 9, 2024

@ulusoyca Thank you for your review. 💙

TahaTesser
TahaTesser approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TahaTesser TahaTesser merged commit 31ffa6f into woltapp:main Dec 10, 2024
3 checks passed
@mukireus mukireus deleted the refactor/clean-folder-structure branch December 10, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TahaTesser TahaTesser TahaTesser approved these changes

@ulusoyca ulusoyca ulusoyca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mukireus @ulusoyca @TahaTesser