Refactor state management for other screens #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulusoyca
reviewed
Oct 27, 2024
|
|
||
| class LoginScreenContent extends StatelessWidget { | ||
| const LoginScreenContent({super.key, required this.onLoginPressed}); | ||
| final LoginScreenViewModel viewModel; |
There was a problem hiding this comment.
The descendent widgets should not know about the view model. We should pass the value listenable from the viewmodel through the root widget.
ulusoyca
reviewed
Oct 27, 2024
|
|
||
| final AuthService _authService; | ||
|
|
||
| final _loginState = StatefulValueNotifier<bool>.idle(false); |
There was a problem hiding this comment.
Let's simplify this by removing the state concept. We can simply name this as isLoggedIn.
ulusoyca
reviewed
Oct 27, 2024
| _viewModel.onLoginPressed(email, password); | ||
| }, | ||
| ); | ||
| return LoginScreenContent(viewModel: _viewModel); |
There was a problem hiding this comment.
The descendents should never have dependency to the ViewModel
ulusoyca
reviewed
Oct 27, 2024
| @@ -0,0 +1,52 @@ | |||
| import 'package:coffee_maker_navigator_2/features/add_water/domain/entities/water_source.dart'; | |||
|
|
|||
| class AddWaterState { | |||
There was a problem hiding this comment.
This new approach aims to avoid creating separate State classes. We should avoid combining multiple fields in one class. For example, the footer widget only depends on errorMessage and isReadyToAddWater and it should not be re-built when waterSource for example changes.
ulusoyca
approved these changes
Nov 20, 2024
ulusoyca
merged commit af87ce3
into
woltapp:state-management-experiments-in-demo-app
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applied new state management approach to other screens and view models