20241105-c89-expansion-etc #8164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eck-source-text, and consistent heap shim usage. .github/workflows/codespell.yml: remove */README_jp.txt from "skip" list. IDE/Renesas/cs+/Projects/t4_demo/README_jp.txt: convert from SHIFT_JIS to UTF-8. cmake/options.h.in: use "#cmakedefine HAVE_PTHREAD 1" to avoid conflict with config.h. configure.ac: add --enable-c89, and remove !ENABLED_OPENSSLEXTRA dependency from AM_CONDITIONAL([BUILD_CRYPTONLY],...). wolfcrypt/src/asn.c: refactor SetOthername() for efficiency, and add PRAGMA_GCC to suppress false positive -Wstringop-overflow associated with -fstack-protector. wolfssl/wolfcrypt/rsa.h: add WC_ prefixes to RSA_PKCS1_PADDING_SIZE and RSA_PKCS1_OAEP_PADDING_SIZE, and define unprefixed compat aliases only if !OPENSSL_COEXIST. wolfssl/wolfcrypt/types.h: #ifdef WOLF_C89, #define WC_BITFIELD unsigned; enhance WOLF_ENUM_DUMMY_LAST_ELEMENT() to include the line number, to construct unique labels given a per-filename argument, to accommodate anonymous enums. examples/asn1/asn1.c: examples/client/client.c: examples/pem/pem.c: examples/server/server.c: wolfcrypt/src/sp_dsp32.c: wolfcrypt/src/wc_port.c: wolfssl/test.h: use XMALLOC/XREALLOC/XFREE consistently, not malloc/realloc/free. wolfcrypt/benchmark/benchmark.c: wolfcrypt/src/memory.c: wolfcrypt/test/test.c: wolfssl/wolfcrypt/mem_track.h: wolfssl/wolfcrypt/settings.h: wolfssl/wolfcrypt/types.h: annotate intentional native heap access with "/* native heap */". wolfcrypt/src/asn.c: wolfssl/callbacks.h: wolfssl/openssl/ec.h: wolfssl/openssl/ssl.h: wolfssl/wolfcrypt/hpke.h: wolfssl/wolfcrypt/types.h: fix enum trailing commas. wolfssl/openssl/ec.h: wolfssl/openssl/evp.h: wolfssl/openssl/rsa.h: wolfssl/openssl/ssl.h: use WC_BITFIELD in bitfield elements, not byte or word16, to allow for pedantic C89 conformant builds. wolfssl/openssl/ec.h: wolfssl/openssl/evp.h: wolfssl/openssl/pem.h: wolfssl/openssl/ssl.h: wolfssl/wolfcrypt/logging.h: avoid variadic macros wherever possible, and where unavoidable, #ifdef WOLF_NO_VARIADIC_MACROS, define them with empty arg lists, rather than ..., to support Watcom compiler. wolfssl/wolfcrypt/settings.h: if defined(__WATCOMC__), define WOLF_NO_VARIADIC_MACROS.
…ing native heap allocations.
dgarske
approved these changes
Nov 8, 2024
| { | ||
| /* can be any value or ignored, rpc layer doesn't care | ||
| * also ok | ||
| * *handle = 0; | ||
| * *handle = 0xdeadc0de; | ||
| */ | ||
| *handle = (remote_handle64)malloc(1); | ||
| *handle = (remote_handle64)XMALLOC(1, NULL, DYNAMIC_TYPE_ECC); |
There was a problem hiding this comment.
@JacobBarthelmeh are these DSP changes okay?
@douzzer why DYNAMIC_TYPE_ECC?
There was a problem hiding this comment.
yeah, that is ok to change
There was a problem hiding this comment.
Should the handle really be only 1 byte? Should it be at least the size of a pointer? Can we choose a better dynamic type?
There was a problem hiding this comment.
It's ok to adjust it to the size of a pointer if wanted. Maybe on the dynamic types it could be DYNAMIC_TYPE_FILE or DYNAMIC_TYPE_NONE or a new DYNAMIC_TYPE such as DYNAMIC_TYPE_HW_HANDLE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assorted cleanups and refactors for C89 conformance,
codespellandcheck-source-text, and consistent heap shim usage..github/workflows/codespell.yml: remove*/README_jp.txtfrom "skip" list.IDE/Renesas/cs+/Projects/t4_demo/README_jp.txt: convert fromSHIFT_JIStoUTF-8.cmake/options.h.in: use#cmakedefine HAVE_PTHREAD 1to avoid conflict withconfig.h.configure.ac: add--enable-c89, and remove !ENABLED_OPENSSLEXTRAdependency fromAM_CONDITIONAL([BUILD_CRYPTONLY],...).wolfcrypt/src/asn.c: refactorSetOthername()for efficiency, and addPRAGMA_GCCto suppress false positive-Wstringop-overflowassociated with-fstack-protector.wolfssl/wolfcrypt/rsa.h: addWC_prefixes toRSA_PKCS1_PADDING_SIZEandRSA_PKCS1_OAEP_PADDING_SIZE, and define unprefixed compat aliases only if !OPENSSL_COEXIST.wolfssl/wolfcrypt/types.h:examples/asn1/asn1.c:examples/client/client.c:examples/pem/pem.c:examples/server/server.c:wolfcrypt/src/sp_dsp32.c:wolfcrypt/src/wc_port.c:wolfssl/test.h:wolfcrypt/benchmark/benchmark.c:wolfcrypt/src/memory.c:wolfcrypt/test/test.c:wolfssl/wolfcrypt/mem_track.h:wolfssl/wolfcrypt/settings.h:wolfssl/wolfcrypt/types.h:wolfcrypt/src/asn.c:wolfssl/callbacks.h:wolfssl/openssl/ec.h:wolfssl/openssl/ssl.h:wolfssl/wolfcrypt/hpke.h:wolfssl/wolfcrypt/types.h:wolfssl/openssl/ec.h:wolfssl/openssl/evp.h:wolfssl/openssl/rsa.h:wolfssl/openssl/ssl.h:wolfssl/openssl/ec.h:wolfssl/openssl/evp.h:wolfssl/openssl/pem.h:wolfssl/openssl/ssl.h:wolfssl/wolfcrypt/logging.h:wolfssl/wolfcrypt/settings.h: ifdefined(__WATCOMC__), defineWOLF_NO_VARIADIC_MACROS.tested with
wolfssl-multi-test.sh ... super-quick-checksee also #8148 -- this fixes the
-Wstringop-overflowreported there.