Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress override suggestions #102

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Suppress override suggestions #102

merged 1 commit into from
Apr 10, 2024

Conversation

fiesh
Copy link

@fiesh fiesh commented Apr 10, 2024

This is necessary since gcc's -Wsuggest-override will also warn at the function definition that an override would be possible.

This copies Q_OBJECT's behavior.

This is necessary since `gcc`'s `-Wsuggest-override` will also warn at
the function definition that an `override` would be possible.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jcelerier
Copy link
Collaborator

LGTM :)

@ogoffart
Copy link
Member

thanks.

@ogoffart ogoffart merged commit b189a97 into woboq:master Apr 10, 2024
24 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants