Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oberursel #169

Closed
wants to merge 6 commits into from
Closed

Oberursel #169

wants to merge 6 commits into from

Conversation

mikafinja
Copy link
Contributor

Added Oberursel marktes.

Copy link
Member

@johnjohndoe johnjohndoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are four more markets listed on the website. Do you want to add them?
Please note you can specify human readable opening hours in the opening_hours_unclassified property if the OpenStreetMap opening hours format does not support parsing the dates.
If you have questions I am happy to help.

@mikafinja
Copy link
Contributor Author

Is there any tag to specify the type of market, e.g. Farmer Market or Flea Market? I didn't find anything in the examples or contribution guide. :(

@johnjohndoe
Copy link
Member

johnjohndoe commented Jan 20, 2017

No, not yet. Market classification is a pending feature, see #65.

@mikafinja
Copy link
Contributor Author

I'll add the flea markets to night, except the Auto-Show because it's not a market, it's more like a car fair sponsored by the city of Oberursel.

@johnjohndoe
Copy link
Member

@telegnom Did you finish you changes? I cannot see any changes yet.

@mikafinja
Copy link
Contributor Author

Not yet, I'm sorry. I was short of time during the last days. I hope I'll have it done by the end of this week.

@johnjohndoe
Copy link
Member

@telegnom Friendly reminder 💐

@johnjohndoe
Copy link
Member

Hey @telegnom, what happened to you 👀 and the missing markets?

@mikafinja
Copy link
Contributor Author

Hi,
a lot of water flowed down the Rhine since I was here for the last time, but let's drop it.

The flea markets 'Kleiner Bücherflohmarkt' and 'Flohmarkt in der Allee' have been added. Even with the field "opening_hours_undefined" in mind, I wasn't able to find a proper way to describe when these markets take place. They are different dates each year, so it's hard to describe.

"type": "Point"
},
"properties": {
"title": "Flohmarkt in der Allee",
Copy link
Member

@johnjohndoe johnjohndoe Jul 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@telegnom "Flohmarkt in der Allee" is contained two times.

@johnjohndoe johnjohndoe dismissed their stale review July 10, 2017 17:03

New commits.

Copy link
Member

@johnjohndoe johnjohndoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@telegnom Please remove duplicate markets if this was not on purpose.

@johnjohndoe
Copy link
Member

@telegnom I rebased and squashed your commits into a single commit here: 47d171a. I also removed the duplicate market. Finally, I merged the your pull request here: f7dea42.

Thanks a lot for your contribution and following up on the change requests.
Now it is the time to spread the word. Here are good starting points:

  • Send a tweet #woistmarkt with a screenshot and a link to the website (please share the tweet link here)
  • Try to convince the city of Oberursel to link to our website, see Promote website #38

@johnjohndoe
Copy link
Member

johnjohndoe commented Jul 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants