-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oberursel #169
Oberursel #169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are four more markets listed on the website. Do you want to add them?
Please note you can specify human readable opening hours in the opening_hours_unclassified
property if the OpenStreetMap opening hours format does not support parsing the dates.
If you have questions I am happy to help.
Is there any tag to specify the type of market, e.g. Farmer Market or Flea Market? I didn't find anything in the examples or contribution guide. :( |
No, not yet. Market classification is a pending feature, see #65. |
I'll add the flea markets to night, except the Auto-Show because it's not a market, it's more like a car fair sponsored by the city of Oberursel. |
@telegnom Did you finish you changes? I cannot see any changes yet. |
Not yet, I'm sorry. I was short of time during the last days. I hope I'll have it done by the end of this week. |
@telegnom Friendly reminder 💐 |
Hey @telegnom, what happened to you 👀 and the missing markets? |
Hi, The flea markets 'Kleiner Bücherflohmarkt' and 'Flohmarkt in der Allee' have been added. Even with the field "opening_hours_undefined" in mind, I wasn't able to find a proper way to describe when these markets take place. They are different dates each year, so it's hard to describe. |
"type": "Point" | ||
}, | ||
"properties": { | ||
"title": "Flohmarkt in der Allee", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@telegnom "Flohmarkt in der Allee" is contained two times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@telegnom Please remove duplicate markets if this was not on purpose.
@telegnom I rebased and squashed your commits into a single commit here: 47d171a. I also removed the duplicate market. Finally, I merged the your pull request here: f7dea42. Thanks a lot for your contribution and following up on the change requests.
|
Added Oberursel marktes.