-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change build to use Vite and Typescript #91
base: main
Are you sure you want to change the base?
Conversation
…mrc. Remove old patch. Better error messages
@C-Loftus. It appears there is something wrong with setting the environment variables in the Docker deployment. I am able to work around this by not setting any variables at root level: Additionally, the UI displays a weird error when there are no observations published from a station. |
Thanks for catching that @webb-ben |
I deployed this version of the wis2box-ui on a test server and I get an error: Test-server at http://136.156.130.194/ |
@webb-ben This should be fixed now if you want to review before the WMO folks. (But anyone feel free to take a look!)Here are some quick screenshots for context to show I fixed the error handling. When used with the test server where there are no observations: Where used with a real wis2box server i.e. the one for South Korea, but with a station with no observations Otherwise everything should be ok and stable. To replicate I did this docker build .
lcp --proxyUrl "https://wis2box.kma.go.kr/"
# or (lcp for http://136.156.130.194/ also works)
docker run -e WIS2BOX_API_URL=http://localhost:8010/proxy/oapi -p 5100:80 sha256:1d5697bd7ef4dd720469
56546a869ceba13a61f6ee476c4b52a12e1f8ab0cceb |
…will update the chart
…'t update if station has no observations
This code does not add any new user-facing behavior and should hopefully not be too hard to review. I kept the same overall components and layout of the codebase since I think it is well thought out.
Before review, goal is to:
const self = this
and any places wherethis
is shadowedthis
--force
or--legacy-peer-deps
Addresses #90