Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to use vite and typescript #90

Open
C-Loftus opened this issue Oct 28, 2024 · 0 comments
Open

Update code to use vite and typescript #90

C-Loftus opened this issue Oct 28, 2024 · 0 comments

Comments

@C-Loftus
Copy link

Currently this repo uses js and vue cli. This is fine, but makes it harder to catch errors and some of the vue tooling is now a bit outdated. The package.json is a bit hard to append to now that some of the older dependencies aren't the recommended option anymore

I believe it would significantly improve developer efficiency to use typescript in the project and use vite. This is the standard recommended setup for new vue projects.

A Potential Plan

I would be happy to submit a PR for the changes described:

  • I would start off by only porting the existing code to typescript and vite
  • I would not add any new dependencies beyond those required for build

After that is merged, then future PRs could be done to make things more idiomatic / add new behavior. However, wanted to keep the start pretty simple.
I don't envision this would be too long to accomplish.

Along the way, I think it would make sense to add a pre-commit config so there is a consistent style across the codebase and no eslint errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant