Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update csv2bufr exercise, add daycli #115

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Conversation

maaikelimper
Copy link
Collaborator

No description provided.

@maaikelimper maaikelimper marked this pull request as draft October 1, 2024 10:38
@maaikelimper maaikelimper marked this pull request as ready for review October 1, 2024 11:32
"day","","Integer","Day (UTC), the time of observation (based on the actual time the barometer is read)"
"hour","","Integer","Hour (UTC), the time of observation (based on the actual time the barometer is read)"
"minute","","Integer","Minute (UTC), the time of observation (based on the actual time the barometer is read)"
"wsi_series"," " ,"Integer","WIGOS identifier series"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add a space, we want an empty string if no units, not a space.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise the page will display "nan", with an empty space the table looks better.

@@ -0,0 +1,53 @@
Column,Units,Data Type,Description
wsi_series, ,Integer,"WIGOS Identifier series, set to 0 for stations"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above re space vs length zero string.

- Depth of fresh snow over 24 hours period

This template requires additional metadata with respect to the simplified AWS-template: method of calculating average temperature; sensor and station heights; exposure and measurement quality classification.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a caveat that the BUFR sequence is planned to be updated.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK added


Navigate to CSV to BUFR submission page on the the wis2box web-application
!!! question
What weather variables are included in the daycli template?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also want to flag the metadata

  • siting and measurement quality classifications for precip and air temperature
  • method of calculating the average temperature
  • quality flags

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I updated the question, I also take note the importance of these fields during the training

@maaikelimper maaikelimper merged commit d5d34f5 into main Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants