local/staging: use argocd-config 1.1.0 #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrow
reviewed
Dec 9, 2024
| @@ -1,2 +1,5 @@ | |||
| chartVersions: | |||
| wbaasUi: 0.4.0 | |||
There was a problem hiding this comment.
I love being explict here; better than the implicit values from the chart
There was a problem hiding this comment.
also allows deployment without a new chart
|
I think this won't use the new argocd-config chart in any environment? We should need to bump the argocd-config version in helmfile.yaml right? |
ah right, thats me getting used to not commit the helmfile.yaml ... |
deer-wmde
commented
Dec 10, 2024
deer-wmde
changed the title
deer-wmde
added a commit
that referenced
this pull request
Dec 12, 2024
This reverts commit dc05e56.
deer-wmde
added a commit
that referenced
this pull request
Dec 12, 2024
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
needs wbstack/charts#173
https://phabricator.wikimedia.org/T377585
deploys/uses wbstack/charts#173 in local & staging