Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable TLS for local environment #1868

Merged
merged 12 commits into from
Dec 10, 2024
Merged

enable TLS for local environment #1868

merged 12 commits into from
Dec 10, 2024

Conversation

deer-wmde
Copy link
Contributor

@deer-wmde deer-wmde commented Nov 22, 2024

Note

depends on: wbstack/charts#179

Describe the changes

  • changes local tunnel script to serve port 443 instead of 80
  • enables TLS for local ingress
  • adds certificate config for self-signed cert-issuer

This is what I need help with

Link to Phabricator

https://phabricator.wikimedia.org/T378691

@tarrow
Copy link
Contributor

tarrow commented Nov 27, 2024

maybe you already did locally and didn't commit but I wondered if you needed to also touch https://github.com/wmde/wbaas-deploy/blob/main/bin/minikube-tunnel#L7 and open 443 there?

@deer-wmde
Copy link
Contributor Author

maybe you already did locally and didn't commit but I wondered if you needed to also touch https://github.com/wmde/wbaas-deploy/blob/main/bin/minikube-tunnel#L7 and open 443 there?

that was it, thanks.

@deer-wmde deer-wmde marked this pull request as ready for review November 27, 2024 16:04
Copy link
Contributor

@tarrow tarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; didn't try locally though! Don't forget to merge the chart first! :)

@deer-wmde deer-wmde merged commit af6b969 into main Dec 10, 2024
3 checks passed
@deer-wmde deer-wmde deleted the de/local-tls branch December 10, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants