-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable TLS for local environment #1868
Conversation
maybe you already did locally and didn't commit but I wondered if you needed to also touch https://github.com/wmde/wbaas-deploy/blob/main/bin/minikube-tunnel#L7 and open 443 there? |
that was it, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me; didn't try locally though! Don't forget to merge the chart first! :)
Note
depends on: wbstack/charts#179
Describe the changes
443
instead of80
This is what I need help with
http://
that still need to be changed somewhere?Link to Phabricator
https://phabricator.wikimedia.org/T378691