Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lift cpu limits for mediawiki resources #1790

Merged
merged 2 commits into from
Oct 1, 2024
Merged

lift cpu limits for mediawiki resources #1790

merged 2 commits into from
Oct 1, 2024

Conversation

deer-wmde
Copy link
Contributor

https://phabricator.wikimedia.org/T375874

as a first step we only lift cpu limits for mw resources and will observe the effect

Copy link
Contributor

@dati18 dati18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, we should bump more on production and less on staging since staging is not as demanding as prod. What do you think?

@tarrow
Copy link
Contributor

tarrow commented Sep 30, 2024

Generally looks fine to me; I struggled to find some docs saying that 0 === unlimited. I don't suppose you have a reference for that?

@deer-wmde
Copy link
Contributor Author

In my opinion, we should bump more on production and less on staging since staging is not as demanding as prod. What do you think?

good thinking, there is missing some detail here: with our GCP resources we are currently on a fixed pre-commited contingent, so there is a lot of cpu we are paying for but not using, otherwise I wouldn't have increased this here for staging

@deer-wmde
Copy link
Contributor Author

deer-wmde commented Sep 30, 2024

Generally looks fine to me; I struggled to find some docs saying that 0 === unlimited. I don't suppose you have a reference for that?

Excellent question, I will verify this on the staging cluster.

update: yeah it has to be null instead

@deer-wmde deer-wmde mentioned this pull request Sep 30, 2024
@deer-wmde deer-wmde requested a review from tarrow September 30, 2024 13:07
@tarrow
Copy link
Contributor

tarrow commented Oct 1, 2024

given you're not here I'm gonna ship this now :)

@tarrow tarrow merged commit 34fb2e4 into main Oct 1, 2024
3 checks passed
@tarrow tarrow deleted the de/lift-mw-cpu-limits branch October 1, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants