Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(k8s): add namespace for running queryservice jobs #1310

Merged
merged 2 commits into from
Dec 13, 2023
Merged

feat(k8s): add namespace for running queryservice jobs #1310

merged 2 commits into from
Dec 13, 2023

Conversation

m90
Copy link
Contributor

@m90 m90 commented Dec 11, 2023

m90
m90 commented Dec 11, 2023
View reviewed changes
tf/env/production/namespaces.tf
}
spec {
hard = {
pods = 4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very (probably too) conservative, but as the setup can create a lot of jobs at once I wanted to keep us from accidentally DOSing ourselves by something we didn't foresee.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, can always go up from here

tarrow
tarrow reviewed Dec 12, 2023
View reviewed changes
tf/env/local/namespaces.tf Outdated Show resolved Hide resolved
@m90 m90 merged commit 9571a3c into main Dec 13, 2023
2 checks passed
@m90 m90 deleted the fr/qs-job-namespace branch December 13, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrow tarrow tarrow left review comments

@deer-wmde deer-wmde deer-wmde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m90 @tarrow @deer-wmde