Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tf): sql alerting policy #1231

Merged
merged 5 commits into from
Nov 9, 2023
Merged

fix(tf): sql alerting policy #1231

merged 5 commits into from
Nov 9, 2023

Conversation

deer-wmde
Copy link
Contributor

@deer-wmde deer-wmde commented Oct 30, 2023 •
edited
Loading

https://phabricator.wikimedia.org/T349817

This PR aggregates the log based metric that is used for the sql backup alerting.

image

@deer-wmde deer-wmde marked this pull request as ready for review October 30, 2023 15:46
m90
m90 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@m90 m90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you still wanna add the changelog entry in this PR so we can tag it once merged?

@deer-wmde deer-wmde merged commit c0c3950 into main Nov 9, 2023
2 checks passed
@deer-wmde deer-wmde deleted the de/231030/fix-sql-backup-monitoring branch November 9, 2023 11:51
@deer-wmde deer-wmde mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrow tarrow tarrow left review comments

@m90 m90 m90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deer-wmde @m90 @tarrow