Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elasticsearch): use 7.10.2 cluster for local and staging #1192

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

AndrewKostka
Copy link
Contributor

No description provided.

@@ -43,6 +43,7 @@ app:
serviceAccountSecret: null
stackdriver:
enabled: false
elasticSearchHost: elasticsearch-1-master-hl.default.svc.cluster.local:9200
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should probably use the "normal" elasticsearch host rather than specifically the master headless one.

I believe in this context the hl version doesn't include the appropriate readiness checks (although we might have turned them off) and also we should probably be aiming at the non-master (coordinating only nodes) anyway (see like the second paragraph of here https://opster.com/guides/elasticsearch/high-availability/coordinating-only-dedicated-coordinating-node/)

Copy link
Contributor

@tarrow tarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool; assume you're gonna follow this up with something to also write to the new cluster, from the platform api, on staging

@AndrewKostka
Copy link
Contributor Author

cool; assume you're gonna follow this up with something to also write to the new cluster, from the platform api, on staging

Yes, but after all existing wikis have been re-indexed on the new Elasticsearch cluster. This can happen at the same time we begin reading from the new cluster. Otherwise, new wikis would have to wait until indexing is complete on all other wikis before they could start using search.

@AndrewKostka AndrewKostka merged commit 1d5a9cc into main Oct 16, 2023
2 checks passed
@AndrewKostka AndrewKostka deleted the forked-elasticsearch-7.10.2-local-staging branch October 16, 2023 11:10
@tarrow
Copy link
Contributor

tarrow commented Oct 16, 2023

You can specify a list: see wbstack/api#624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants