Bump @vue/test-utils from 2.3.2 to 2.4.1 #492
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/vue/test-utils-2.4.1
branch
from
769c29f to
7f71d65
Compare
|
@dependabot rebase |
Bumps [@vue/test-utils](https://github.com/vuejs/test-utils) from 2.3.2 to 2.4.1. - [Release notes](https://github.com/vuejs/test-utils/releases) - [Commits](vuejs/test-utils@v2.3.2...v2.4.1) --- updated-dependencies: - dependency-name: "@vue/test-utils" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/vue/test-utils-2.4.1
branch
from
7f71d65 to
d319a98
Compare
|
The error in diff --git a/tests/unit/components/LemmaInput.test.ts b/tests/unit/components/LemmaInput.test.ts
index 9eb60cd6b9..37d6c66626 100644
--- a/tests/unit/components/LemmaInput.test.ts
+++ b/tests/unit/components/LemmaInput.test.ts
@@ -1,8 +1,8 @@
import { MessagesKey } from '@/plugins/MessagesPlugin/Messages';
import {
+ ComponentMountingOptions,
DOMWrapper,
mount,
- MountingOptions,
} from '@vue/test-utils';
import LemmaInput from '@/components/LemmaInput.vue';
import { ConfigKey } from '@/plugins/ConfigPlugin/Config';
@@ -20,7 +20,7 @@ describe( 'LemmaInput', () => {
let store: Store<RootState>;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
- function createComponent( config: Partial<MountingOptions<any>> = {} ) {
+ function createComponent( config: Pick<ComponentMountingOptions<any>, 'props' | 'global'> = {} ) {
store = initStore( {
lexemeCreator: unusedLexemeCreator,
langCodeRetriever: unusedLangCodeRetriever,
@@ -29,7 +29,6 @@ describe( 'LemmaInput', () => {
} );
return mount( LemmaInput, {
- ...config,
props: {
modelValue: '',
...config.props,(I’m not sure if the change from But the two other type errors are in Vue Test Utils itself, and I suspect they might require a newer Vue.js version to solve – but we want to keep the Vue version in sync with MediaWiki core. So I think this is stalled for now. |
The `...config` in particular was causing type issues when upgrading @vue/test-utils in #492; and while that pull request is also blocked for other reasons, I think we can make our lives easier by simplifying these types. Callers of this method (which is local to this one test file) only pass in props and/or global.provide, so we can just specify the types for those members instead of full ComponentOptions; the Props type from LemmaInput is just duplicated, since I think that’s simpler than trying to get it back out of the full/exported LemmaInput type again. Bug: T348108
The `...config` in particular was causing type issues when upgrading @vue/test-utils in #492; and while that pull request is also blocked for other reasons, I think we can make our lives easier by simplifying these types. Callers of this method (which is local to this one test file) only pass in props and/or global.provide, so we can just specify the types for those members instead of full ComponentOptions; the Props type from LemmaInput is just duplicated, since I think that’s simpler than trying to get it back out of the full/exported LemmaInput type again. Bug: T348108
Done (somewhat differently) in #535.
This is still the case; should be retried once there’s a new VTU release (or MediaWiki updates its Vue version). |
|
The type errors still persist in 2.4.2, as far as I can tell from a local test ( |
|
Superseded by #576. |
dependabot
bot
deleted the
dependabot/npm_and_yarn/vue/test-utils-2.4.1
branch
Bumps @vue/test-utils from 2.3.2 to 2.4.1.
Release notes
Sourced from
@vue/test-utils's releases.... (truncated)
Commits
6af516apublish: 2.4.1c41e914chore(deps): update typescript-eslint monorepo to v6 (#2129)e235e3afix: modify createVMProxy (#2125)a304f59chore: exception for no-extra-semi lint rule881646echore(deps): update dependency js-beautify to v1.14.95426ca2chore(deps): update vitest to v0.33.0136e67bchore(deps): update dependency prettier to v3 and eslint-plugin-prettier to v5ffbb7cfchore(deps): update all non-major dependenciesf0df231docs: add warning aboutisVisible()73890efchore(deps): update vitest to v0.32.4You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)