Skip to content

Commit

Permalink
Wikit cleanup
Browse files Browse the repository at this point in the history
Wikit is no longer being used. This commit removes the references
that remained at the end of the migration from wikit to codex

Bug: T376718
  • Loading branch information
yerdua committed Oct 28, 2024
1 parent b8a180d commit bda6883
Show file tree
Hide file tree
Showing 11 changed files with 1 addition and 135 deletions.
3 changes: 0 additions & 3 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ module.exports = {
// resetting this back to the default value, to comply with modern vite conventions
'vue/component-tags-order': [ 'error', { order: [ [ 'script', 'template' ], 'style' ] } ],

// we still need to use some legacy APIs to interact with the vue3compat build of Wikit
'vue/no-deprecated-v-on-native-modifier': 'off',

// rule has no support for our @/ aliases;
// the designated replacement, plugin:import, was a pain so we ditched it
'n/no-missing-import': 'off',
Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,6 @@ npm run cypress:open
You can see which dependencies have new releases by first making sure your local dependencies are up-to-date by executing `npm ci` and then running `npm outdated`.
The following dependencies should be ignored:

- Wikit (i.e. `@wmde/wikit-tokens` and `@wmde/wikit-vue-components`):
we’re using a newer pre-release version and don’t want to downgrade to the latest full release.
- Vue and Vuex:
in production, we use the versions shipped by MediaWiki core,
so we should use the same versions for testing.
Expand Down
83 changes: 0 additions & 83 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@
"@wikimedia/codex": "^1.14.0",
"@wikimedia/codex-design-tokens": "^1.14.0",
"@wmde/wikibase-datamodel-types": "^0.2.0",
"@wmde/wikit-tokens": "^3.0.0-alpha.12",
"@wmde/wikit-vue-components": "^3.0.0-alpha.12",
"jest-environment-jsdom": "^29.7.0",
"vue": "3.4.27",
"vuex": "4.0.2"
Expand Down
1 change: 0 additions & 1 deletion src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import AnonymousEditWarning from '@/components/AnonymousEditWarning.vue';
import NewLexemeForm from '@/components/NewLexemeForm.vue';
import SearchExisting from '@/components/SearchExisting.vue';
import '@wmde/wikit-vue-components/dist/wikit-vue-components.css';
</script>

Expand Down
7 changes: 0 additions & 7 deletions src/components/LanguageInput.vue
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,4 @@ export default {

<style lang="scss">
@import '@wikimedia/codex-design-tokens/theme-wikimedia-ui';
/* stylelint-disable selector-class-pattern */
.wbl-snl-language-lookup .wikit .wikit-Lookup__label-wrapper {
gap: $spacing-50;
}
/* stylelint-enable selector-class-pattern */
</style>
6 changes: 0 additions & 6 deletions src/components/LexicalCategoryInput.vue
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,4 @@ export default {

<style lang="scss">
@import '@wikimedia/codex-design-tokens/theme-wikimedia-ui';
/* stylelint-disable selector-class-pattern */
.wbl-snl-lexical-category-lookup .wikit .wikit-Lookup__label-wrapper {
gap: $spacing-50;
}
/* stylelint-enable selector-class-pattern */
</style>
6 changes: 0 additions & 6 deletions src/components/SpellingVariantInput.vue
Original file line number Diff line number Diff line change
Expand Up @@ -133,12 +133,6 @@ export default {
@import '@wikimedia/codex-design-tokens/theme-wikimedia-ui';
.wbl-snl-spelling-variant-lookup {
/* stylelint-disable plugin/stylelint-bem-namics, selector-class-pattern */
&.wikit .wikit-Lookup__label-wrapper {
gap: $spacing-50;
}
/* stylelint-enable plugin/stylelint-bem-namics, selector-class-pattern */
&__help-link {
padding-bottom: $spacing-50;
display: inline-block;
Expand Down
20 changes: 0 additions & 20 deletions src/components/WikitLookup.ts

This file was deleted.

2 changes: 1 addition & 1 deletion tests/integration/NewLexemeForm.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ describe( 'NewLexemeForm', () => {
await selectLanguage( wrapper );
await nextTick();

const warning = wrapper.find( '.wikit-ValidationMessage--warning' );
const warning = wrapper.find( '.cdx-message--warning' );
expect( warning.exists() ).toBe( false );

const spellingVariantLookup = wrapper.find( '.wbl-snl-spelling-variant-lookup input' );
Expand Down
4 changes: 0 additions & 4 deletions vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ export default defineConfig( {
build: getBuildConfig( !!process.env.BUILD_AS_APP ),
resolve: {
alias: {
'@wmde/wikit-tokens/variables': resolve(
__dirname,
'node_modules/@wmde/wikit-tokens/dist/_variables.scss',
),
'@': resolve( __dirname, 'src' ),
},
},
Expand Down

0 comments on commit bda6883

Please sign in to comment.