Skip to content

Commit

Permalink
Add the reason why we cannot update the Node.js version to the README
Browse files Browse the repository at this point in the history
I forget about every two months why exactly we cannot upgrade to a newer
node version just in the GitHub actions/workflows. Better write that
down right where one would expect it.
  • Loading branch information
micgro42 committed Jan 2, 2024
1 parent c4d29f4 commit 9833d61
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,10 @@ The following dependencies should be ignored:
- lint-staged:
[v15.0.0](https://github.com/lint-staged/lint-staged/releases/tag/v15.0.0) drops compatibility with Node 16,
which we still use in CI (see also “Prerequisites” above; Node 18 upgrade pending in [T331180](https://phabricator.wikimedia.org/T331180)).
- Node.js version:
The GitHub Workflows here should use the same Node.js version as the `mwgate-nodeXX-docker` CI job in WikibaseLexeme,
because that job builds this app for the `test:snl-distnodiff` script.
The upgrade to Node 18 there is tracked in [T331180](https://phabricator.wikimedia.org/T331180).

All other dependencies should generally be updated to the latest version.
If you discover that a dependency should not be updated for some reason, please add it to the above list.
Expand Down

0 comments on commit 9833d61

Please sign in to comment.