Skip to content

Commit

Permalink
Remove TypeScript and Vue Test Utils notes from README.md (#581)
Browse files Browse the repository at this point in the history
Now that we upgraded from Vue 3.2 to 3.3, TypeScript is no longer
*known* to be blocked, so the next round of chores should attempt to
upgrade it. If there are any problems, we can add it back to the list.

Whether Vue Test Utils is unblocked is even less clear to me, but let’s
still remove it and potentially put it back if needed.

Bug: T352388
  • Loading branch information
lucaswerkmeister authored Nov 30, 2023
1 parent ed0ad3e commit 57a6eb7
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,17 +100,12 @@ The following dependencies should be ignored:
in production, we use the versions shipped by MediaWiki core,
so we should use the same versions for testing.
The current versions shipped by MediaWiki core are listed in [foreign-resources.yaml](https://gerrit.wikimedia.org/g/mediawiki/core/+/master/resources/lib/foreign-resources.yaml).
- Typescript:
Vue up until version 3.2.38 (which we currently use) [doesn't support typescript 4.8+](https://github.com/vuejs/core/issues/6554).
- Prettier:
[Jest 29.65.2](https://github.com/jestjs/jest/blob/main/CHANGELOG.md#2962) is not compatible with Prettier 3.
This might be resolved with the next release ([Jest#14566](https://github.com/jestjs/jest/pull/14566)),
so be sure to check whether a newer Jest version is available that includes Prettier 3 compatibility.
- ESLint and some related packages:
Known issues ([T341552](https://phabricator.wikimedia.org/T341552)) that are beyond the scope of chores.
- Vue Test Utils (`@vue/test-utils`):
Seems to require a newer Vue.js version (see [#492](https://github.com/wmde/new-lexeme-special-page/pull/492)),
though it’s worth checking whether that’s still the case in newer VTU versions.
- lint-staged:
[v15.0.0](https://github.com/lint-staged/lint-staged/releases/tag/v15.0.0) drops compatibility with Node 16,
which we still use in CI (see also “Prerequisites” above; Node 18 upgrade pending in [T331180](https://phabricator.wikimedia.org/T331180)).
Expand Down

0 comments on commit 57a6eb7

Please sign in to comment.