C24_WMDE_Desktop_DE_22 #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sperling-0
force-pushed
the
C24_WMDE_Desktop_DE_22
branch
2 times, most recently
from
0816c5d to
9b2fa39
Compare
moiikana
force-pushed
the
C24_WMDE_Desktop_DE_21
branch
from
04f70d5 to
07a2777
Compare
Sperling-0
force-pushed
the
C24_WMDE_Desktop_DE_22
branch
from
9b2fa39 to
6505d7d
Compare
Abban
reviewed
Dec 19, 2024
| @@ -12,7 +12,7 @@ | |||
| @use 'Banner'; | |||
| @use 'src/themes/UseOfFunds/UseOfFunds'; | |||
| @use 'MainBanner' with ( | |||
| $banner-height: 357px, | |||
| $banner-height: 368.8px, | |||
There was a problem hiding this comment.
Giving this a fractional value will cause issues as OSs/browsers do subpixel rendering differently, and it's considered to not be a best practice in CSS. I would recommend leaving it at 357px, and reducing the font size of the text in the message in both banners.
There was a problem hiding this comment.
You can actually look at the en banner for this, as that also has a load of text
There was a problem hiding this comment.
We had the slider break point increased at 1550 as suggested by the PM.
Sperling-0
force-pushed
the
C24_WMDE_Desktop_DE_22
branch
2 times, most recently
from
021e3b1 to
9ccad6b
Compare
- The banner is based on CTRL of desktop-de-21 Ticket: https://phabricator.wikimedia.org/T382301
Sperling-0
force-pushed
the
C24_WMDE_Desktop_DE_22
branch
from
9ccad6b to
e619261
Compare
Sperling-0
force-pushed
the
C24_WMDE_Desktop_DE_22
branch
from
e619261 to
7828641
Compare
- Var has a different copy - Adjust the banner height, so that both the banners have same height - Make slider breakpoint at larger width - Adjust the tests accordingly Ticket: https://phabricator.wikimedia.org/T382301
Sperling-0
force-pushed
the
C24_WMDE_Desktop_DE_22
branch
from
7828641 to
36f51e3
Compare
moiikana
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both banners:Variant banner:Ticket: https://phabricator.wikimedia.org/T382301