Add new Use of Funds 2024 modal #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abban
force-pushed
the
C24_WMDE_Mobile_DE_13
branch
2 times, most recently
from
b578e82 to
593515b
Compare
gbirke
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
I've user-tested it and found two bugs:
- Content is missing. Please reset package-lock.json and use
npm run update-contentto update the new content. - The close button doesn't work. Console shows
Uncaught TypeError: payload is undefinedin the onCloseModal handler in the banner component
Abban
force-pushed
the
use_of_funds_2024
branch
8 times, most recently
from
abb2081 to
34cf688
Compare
- Add new use of funds components and styles. - Add duplicate interface, environment imports and content loaders for the new content structure. - Add tests. - Add details to clean up document. Ticket: https://phabricator.wikimedia.org/T381411
moiikana
force-pushed
the
use_of_funds_2024
branch
from
34cf688 to
2f86b06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
content loaders for the new content structure.
Ticket: https://phabricator.wikimedia.org/T381411