C24_WMDE_Desktop_DE_20 #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sperling-0
force-pushed
the
C24_WMDE_Desktop_DE_20
branch
from
3c7c39e to
bbda409
Compare
Sperling-0
force-pushed
the
C24_WMDE_Desktop_DE_19
branch
from
5a476d6 to
966f202
Compare
Sperling-0
force-pushed
the
C24_WMDE_Desktop_DE_20
branch
18 times, most recently
from
5e08098 to
45998c2
Compare
Sperling-0
force-pushed
the
C24_WMDE_Desktop_DE_19
branch
from
966f202 to
7ec68b2
Compare
- Emit the event `modalOpened` when the use of funds modal is opened. - Emit the event `modalClosed` when the use of funds modal is closed. - The variant banner design is changed according to the design file for the slider and the non-slider. - The variant banner integrates the "10 good reasons" feature using the sticker. - Diverging from the design, the additional element should be at the bottom (sharing the space with the slide indicators) to prevent overlapping. - Hovering over the new element: - turns the cursor into a pointer. - adds underlining to the link text. - Interaction with `ReasonsToDonate` is tracked - Add tests for VAR banner Ticket: https://phabricator.wikimedia.org/T380852
- The banners are based on the control banner of desktop-de-19 Ticket: https://phabricator.wikimedia.org/T381401
- The variant banner is changed according to the design file:
- The progress bar is split out of the red bordered box.
- Another progress bar is added showing the number of campaign days passed.
- Use late progress double progress bar
- Update Clean up 2025 document
Ticket: https://phabricator.wikimedia.org/T381401
Sperling-0
force-pushed
the
C24_WMDE_Desktop_DE_20
branch
from
45998c2 to
4dbac39
Compare
moiikana
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bothbanners:Varbanner:The variant banner is changed according to the design file:
Use late progress double progress bar
Update Clean up 2025 document
Ticket: https://phabricator.wikimedia.org/T381401