Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C24_WMDE_Desktop_EN_06 #654

Merged
merged 4 commits into from
Dec 11, 2024
Merged

C24_WMDE_Desktop_EN_06 #654

merged 4 commits into from
Dec 11, 2024

Conversation

gbirke
Copy link
Member

@gbirke gbirke commented Dec 9, 2024

Test double progress bar (with late-progress enabled)

Ticket: https://phabricator.wikimedia.org/T381396

@gbirke gbirke force-pushed the C24_WMDE_Desktop_EN_06 branch 3 times, most recently from 9ad761f to 1823999 Compare December 11, 2024 15:51
Add double progress bar to VAR

- add comment to `currentCampaignTimePercentage`
- add English translations for `DoubleProgressBar` component
- switch back to "million" formatting (instead of whole number
  formatting) for the "amount remaining" in the late progress content.
  This was switched before in 2023 Desktop DE 24

Ticket: https://phabricator.wikimedia.org/T381396
@gbirke gbirke force-pushed the C24_WMDE_Desktop_EN_06 branch from 1823999 to efce923 Compare December 11, 2024 16:00
@moiikana moiikana merged commit a635b8c into main Dec 11, 2024
1 check passed
@moiikana moiikana deleted the C24_WMDE_Desktop_EN_06 branch December 11, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants