-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- everytime a PR gets labeled with "Ready for review" the playbook job runs ( npm run ci and npm run test:all-banners) - this could increase the response time to errors compared to scheduled checks per day (at midnight e.g)
- Loading branch information
Showing
2 changed files
with
29 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
name: BC check for all banners on "Ready for review" label | ||
#Check backwards compatibility for all Banners whenever "Ready for review" label is added to a pull request | ||
on: | ||
pull_request: | ||
types: [ labeled ] | ||
|
||
jobs: | ||
bc-check: | ||
if: ${{ github.event.label.name == 'Ready for review' }} | ||
runs-on: ubuntu-latest | ||
|
||
strategy: | ||
matrix: | ||
node-version: [18.x] | ||
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/ | ||
# Node version should be in sync with the version in the package.json and build.yml | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Use Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
cache: 'npm' | ||
# Install packages, exact versions from package-lock.json | ||
- run: npm ci | ||
# Run test case that runs unit tests for all banners | ||
- run: npm run test:all-banners |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ on: | |
- cron: "0 0 * * *" | ||
|
||
jobs: | ||
bc-check: | ||
daily-bc-check: | ||
runs-on: ubuntu-latest | ||
|
||
strategy: | ||
|