Skip to content

Commit

Permalink
Add link titles to banner links
Browse files Browse the repository at this point in the history
- gives the user a popup that says what the link does
  • Loading branch information
moiikana committed Dec 16, 2024
1 parent ae91841 commit f32606e
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 4 deletions.
6 changes: 5 additions & 1 deletion src/components/FallbackBanner/UseOfFundsLink.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
<template>
<a class="wmde-banner-fallback-usage-link" @click.prevent="$emit( 'button-clicked' )">
<a
class="wmde-banner-fallback-usage-link"
@click.prevent="$emit( 'button-clicked' )"
:title="$translate( 'use-of-funds-link-description' )"
>
{{ $translate( 'use-of-funds-link' ) }}
</a>
</template>
Expand Down
1 change: 1 addition & 0 deletions src/components/Footer/BannerFooter.vue
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
id="application-of-funds-link"
class="wmde-banner-footer-usage-link t-use-of-funds-link"
@click.prevent="$emit( 'showFundsModal' )"
:title="$translate( 'use-of-funds-link-description' )"
>
{{ $translate( 'use-of-funds-link' ) }}
</a>
Expand Down
8 changes: 7 additions & 1 deletion src/components/Footer/FooterAlreadyDonated.vue
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@
<label class="wmde-banner-footer-bank-item iban">IBAN:
<SelectionInput :value="'DE09 3702 0500 0003 2873 00'" :focusedValue="'DE09370205000003287300'"/>
</label>
<a href="#" class="wmde-banner-footer-already-donated" @click.prevent="onClickAlreadyDonated">
<a
href="#"
class="wmde-banner-footer-already-donated"
@click.prevent="onClickAlreadyDonated"
:title="$translate( 'already-donated-description' )"
>
<TickIcon :fill="'#5B5B5B'"/> {{ $translate( 'already-donated-open-link' ) }}
</a>
</div>
Expand All @@ -21,6 +26,7 @@
id="application-of-funds-link"
class="wmde-banner-footer-usage-link t-use-of-funds-link"
@click.prevent="$emit( 'showFundsModal' )"
:title="$translate( 'use-of-funds-link-description' )"
>
{{ $translate('use-of-funds-link') }}
</a>
Expand Down
3 changes: 2 additions & 1 deletion src/components/Footer/messages/Footer.de.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ const translations: TranslationMessages = {
'use-of-funds-link': 'Was Ihre Spende bewirkt',
'use-of-funds-link-description': 'Erklärungstext aufklappen',
'faq-page-link': 'Häufige Fragen zur Spende',
'faq-page-link-description': 'Webseite in neuem Browsertab bzw. -fenster öffnen'
'faq-page-link-description': 'Webseite in neuem Browsertab oder Fenster öffnen',
'already-donated-description': 'Banner schließen'
};

export default translations;
3 changes: 2 additions & 1 deletion src/components/Footer/messages/Footer.en.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ const translations: TranslationMessages = {
'use-of-funds-link': 'Where does my donation go?',
'use-of-funds-link-description': 'expand explanation text',
'faq-page-link': 'FAQ',
'faq-page-link-description': 'open webpage in a new browser tab or window'
'faq-page-link-description': 'open webpage in a new browser tab or window',
'already-donated-description': 'close banner'
};

export default translations;

0 comments on commit f32606e

Please sign in to comment.