Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Suffix… to PrefixedEntityIdParser #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename Suffix… to PrefixedEntityIdParser #137

wants to merge 1 commit into from

Conversation

thiemowmde
Copy link
Contributor

This is not a parser for entity IDs with suffixes. We (@adrianheine and I) found this confusing today.

This is used in two places in the top level factories of Wikibase.git, nowhere else.

@JeroenDeDauw
Copy link
Contributor

+2 CR; suggest to wait with merge till concrete plans to do the next breaking release

@thiemowmde thiemowmde added this to the 4.0.0 milestone Apr 29, 2016
@thiemowmde
Copy link
Contributor Author

I agree.

@brightbyte
Copy link

Needs rebase. Is this still wanted/needed?

@thiemowmde
Copy link
Contributor Author

Rebased. I believe this should still be done. The current name sounds like it is a parser that extracts suffixes, but it does the opposite. It parses EntityIDs that are prefixed.

@JeroenDeDauw
Copy link
Contributor

Needs rebase again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeroenDeDauw JeroenDeDauw JeroenDeDauw approved these changes

Assignees
No one assigned
Labels
breaking
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thiemowmde @JeroenDeDauw @brightbyte