Merge pull request #134 from wmde/todoComments

Add TODOs to various diff(er)s and patchers

src/Diff/EntityDiff.php

@@ -76,6 +76,8 @@ protected function fixSubstructureDiff( array &$operations, $key ) {
 	}
 
 	/**
+	 * FIXME: Not all entities do have aliases!
+	 *
 	 * Returns a Diff object with the aliases differences.
 	 *
 	 * @return Diff
@@ -85,6 +87,8 @@ public function getAliasesDiff() {
 	}
 
 	/**
+	 * FIXME: Not all entities do have labels!
+	 *
 	 * Returns a Diff object with the labels differences.
 	 *
 	 * @return Diff
@@ -94,6 +98,8 @@ public function getLabelsDiff() {
 	}
 
 	/**
+	 * FIXME: Not all entities do have descriptions!
+	 *
 	 * Returns a Diff object with the descriptions differences.
 	 *
 	 * @return Diff
@@ -103,6 +109,8 @@ public function getDescriptionsDiff() {
 	}
 
 	/**
+	 * FIXME: Not all entities do have claims a.k.a. statements!
+	 *
 	 * Returns a Diff object with the claim differences.
 	 *
 	 * @return Diff

src/Diff/Internal/FingerprintPatcher.php

@@ -16,6 +16,9 @@
 use Wikibase\DataModel\Term\TermList;
 
 /**
+ * TODO: Class should be public (or split, and these should be public).
+ * TODO: Should this support actual edit conflict detection?
+ *
  * Package private.
  *
  * @license GPL-2.0+

src/Diff/Internal/SiteLinkListPatcher.php

@@ -10,6 +10,9 @@
 use Wikibase\DataModel\SiteLinkList;
 
 /**
+ * TODO: Class should be public.
+ * TODO: Should this support actual edit conflict detection?
+ *
  * Package private.
  *
  * @license GPL-2.0+

src/Diff/Internal/StatementListDiffer.php

@@ -9,6 +9,8 @@
 use Wikibase\DataModel\Statement\StatementList;
 
 /**
+ * TODO: Class must be public.
+ *
  * Package private.
  *
  * @since 1.0

src/Diff/Internal/StatementListPatcher.php

@@ -10,6 +10,9 @@
 use Wikibase\DataModel\Statement\StatementList;
 
 /**
+ * TODO: Class must be public.
+ * TODO: Should this support actual edit conflict detection?
+ *
  * Package private.
  *
  * @since 1.0