-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated PHP version requirement to ^8.1. #264
base: master
Are you sure you want to change the base?
Conversation
Hi @aurelie1vndl , thank you for your contributions, here and in wmde/WikibaseDataModelServices#250 A good while ago, WMDE engineers have decided to move the development of those Wikibase data model * libraries into Wikibase software's "monorepo". In practice this means that those github repositories are sort of read-only mirrors, while the contributions should be targeting the code under lib/packages directory I'm sorry that it has not been clearly described in this repository. We should have provided contributions guidelines when this change has taken place. Please let me know (eg. by commenting here) if you have trouble re-submitting this PR to Wikimedia Gerrit. I'd be also happy sending it on your behalf (keeping you as git author) I also see WMDE, somehow along with this move to "monorepo", has fallen behind with publishing versions of those data model libraries to be installed with composer. We should fix this, thanks for spotting and apologies for the inconvenience.
Finally, I'd be curious to hear, if you don't mind, what project are you using those libraries, seems quite interesting. |
Well apologies, I misread commit messages. Your PR not dropping PHP 7.4 support so it is all good. |
Hello @manickik Many thanks for the fast reply and for the additional information regarding Wikibase. At first, I was not quite aware of the monorepo "addwiki/addwiki", as our development started from the repository "addwiki/wikibase-api" (v0.8.0) and needs an upgrade after upgrading our project to Drupal 10. After that awareness (ref. addwiki/mediawiki-api-base#52), I've submitted some PR's (starting from the monorepo directory "/packages"), in order to have PHP8.1 supported there as well:
Regarding the curiousness, I'll get back to you in approx. 2 weeks (due to the summer holidays). Kind regards, |
Changes:
Details:
PHPUnit: