Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PHP version requirement to ^8.1. #264

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

aurelie1vndl
Copy link

Changes:

  • Updated PHP version requirement to ^8.1.
  • Updated wikibase/data-model version requirement to dev-master#commit (9.6.1).
  • Added wikibase/data-model-services with version ^5.4.0 to the require section.
  • Updated data-values/geo version requirement to ^4.4.
  • Updated data-values/number version requirement to ^0.12.1.
  • Updated data-values/time version requirement to ^1.1.

Details:

  • The PHP version requirement has been updated to ensure compatibility with newer PHP versions.
  • The wikibase/data-model dependency has been updated to a fixed recent version (the 9.6.1 tag release doesn't seem to have the NumericPropertyId class yet, hence the reference to the commit on the master-branch).
  • Added wikibase/data-model-services to the require section to include necessary services (see existing use in d4c11dd)
  • Updated development dependencies to their latest versions to ensure compatibility and stability during development and testing.

PHPUnit:

WikibaseDataModelSerialization on  composer-fixes [?] via 🐘 v8.1.29 
➜ ./vendor/bin/phpunit tests 
PHPUnit 8.5.39 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.29
Configuration: /WikibaseDataModelSerialization/phpunit.xml.dist

...............................................................  63 / 371 ( 16%)
............................................................... 126 / 371 ( 33%)
............................................................... 189 / 371 ( 50%)
............................................................... 252 / 371 ( 67%)
............................................................... 315 / 371 ( 84%)
........................................................        371 / 371 (100%)

Time: 480 ms, Memory: 24.00 MB

OK (371 tests, 392 assertions)

@manicki
Copy link
Member

manicki commented Jul 26, 2024

Hi @aurelie1vndl , thank you for your contributions, here and in wmde/WikibaseDataModelServices#250
I awe you a bit of explanation and apology on behalf of Wikimedia Germany, (WMDE) maintainer of these libraries.

A good while ago, WMDE engineers have decided to move the development of those Wikibase data model * libraries into Wikibase software's "monorepo". In practice this means that those github repositories are sort of read-only mirrors, while the contributions should be targeting the code under lib/packages directory
You'd need Wikimedia Developer account in order to submit contributions to Wikimedia Gerrit, code review and hosting solution used instead of Github there.

I'm sorry that it has not been clearly described in this repository. We should have provided contributions guidelines when this change has taken place.

Please let me know (eg. by commenting here) if you have trouble re-submitting this PR to Wikimedia Gerrit. I'd be also happy sending it on your behalf (keeping you as git author)

I also see WMDE, somehow along with this move to "monorepo", has fallen behind with publishing versions of those data model libraries to be installed with composer. We should fix this, thanks for spotting and apologies for the inconvenience.

I shall note however that a prominent user of this library, i.e. Wikidata, still runs in the PHP 7.4 environment. Therefore ensuring/declaring compatibility with PHP 8.2+ is nice, but should not drop 7.4 support just yet.

Finally, I'd be curious to hear, if you don't mind, what project are you using those libraries, seems quite interesting.

@manicki
Copy link
Member

manicki commented Jul 26, 2024

Well apologies, I misread commit messages. Your PR not dropping PHP 7.4 support so it is all good.

@aurelie1vndl
Copy link
Author

Hello @manickik

Many thanks for the fast reply and for the additional information regarding Wikibase.
I'll have a closer look on pushing the PR changes via Wikimedia Developer account.

At first, I was not quite aware of the monorepo "addwiki/addwiki", as our development started from the repository "addwiki/wikibase-api" (v0.8.0) and needs an upgrade after upgrading our project to Drupal 10.

After that awareness (ref. addwiki/mediawiki-api-base#52), I've submitted some PR's (starting from the monorepo directory "/packages"), in order to have PHP8.1 supported there as well:

Regarding the curiousness, I'll get back to you in approx. 2 weeks (due to the summer holidays).

Kind regards,
Aurélie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants