Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.2.0 #170

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Bump version to 1.2.0 #170

merged 1 commit into from
Dec 12, 2024

Conversation

codders
Copy link
Contributor

@codders codders commented Dec 11, 2024

  • Drop support for PHP 7.2, 7.3
  • Upgrade codesniffer rules to current mediawiki/mediawiki-codesniffer version (45.0.0)
  • Make nullable type parameter declarations explicit for compatibility with PHP 8.4

Bug: T379481

Copy link
Member

@lucaswerkmeister lucaswerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(GitHub won’t let me comment on lines that weren’t touched on this change, but) comparison with #164 suggests that it would be nice to update the installation instructions in line 30 from ~1.1 to ~1.2. (And, as I was too late to review this today, bump the date to 12 December.)

* Drop support for PHP 7.2, 7.3
* Upgrade codesniffer rules to current `mediawiki/mediawiki-codesniffer` version (45.0.0)
* Make nullable type parameter declarations explicit for compatibility with PHP 8.4

Bug: T379481
@codders codders force-pushed the feat/bump-version-1.2.0 branch from ba1808b to 3c53902 Compare December 12, 2024 08:43
@codders
Copy link
Contributor Author

codders commented Dec 12, 2024

(GitHub won’t let me comment on lines that weren’t touched on this change, but) comparison with #164 suggests that it would be nice to update the installation instructions in line 30 from ~1.1 to ~1.2. (And, as I was too late to review this today, bump the date to 12 December.)

Done

@lucaswerkmeister lucaswerkmeister merged commit d8e8cf7 into master Dec 12, 2024
6 checks passed
@lucaswerkmeister lucaswerkmeister deleted the feat/bump-version-1.2.0 branch December 12, 2024 12:15
@lucaswerkmeister
Copy link
Member

Merged, I’ll let you push the tag :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants