Upgrade mediawiki-codesniffer to latest version (45.0.0) #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaswerkmeister
approved these changes
Dec 9, 2024
codders
force-pushed
the
feat/upgrade-mediawiki-codesniffer-20241206
branch
from
6f464b9 to
8552423
Compare
lucaswerkmeister
approved these changes
Dec 9, 2024
manicki
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
looks great.
CI story is hopefully resolved through #169
Can have a look at the test run for this PR dumbly merged on the CI PR: https://github.com/wmde/Time/actions/runs/12265937550/job/34223058506 (tests pass, no PHP 8.4 warnings)
This repository is currently using version 34 of the Mediawiki coding style phpcs rules. It should be upgraded to the latest version. Besides being simply different, the newer versions of the rules introduce, for example, MediaWiki.Usage.NullableType.ExplicitNullableTypes, which enforces compliance with coming deprecation rules in PHP 8.4 concerning nullable types. If the code does not remove the soon-to-be-deprecated form of nullable type declarations, the library will no longer be usable in Mediawiki for PHP 8.4 deployments. Bug: T379481
codders
force-pushed
the
feat/upgrade-mediawiki-codesniffer-20241206
branch
from
8552423 to
7af710b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repository is currently using version 34 of the Mediawiki coding style phpcs rules. It should be upgraded to the latest version.
Besides being simply different, the newer versions of the rules introduce, for example,
MediaWiki.Usage.NullableType.ExplicitNullableTypes, which enforces compliance with coming deprecation rules in PHP 8.4 concerning nullable types. If the code does not remove the soon-to-be-deprecated form of nullable type declarations, the library will no longer be usable in Mediawiki for PHP 8.4 deployments.
Bug: T379481