-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Less strict array req in UnboundedQuantityValue::newFromArray (#105)
Users of newFromArray give no guarantee that the value passed in is actually the array. DataValueObject::requireArrayFields asserts that the value is an array, and throws the exception that callers can handle. Having no strict array requirement lets callers handle erroneous input nicer. Other DataValue classes already seem to follow similar pattern. Strict array requirement was related to: https://phabricator.wikimedia.org/T168681
- Loading branch information
1 parent
c84e181
commit 6498e61
Showing
2 changed files
with
11 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters