Explicit linking behavior #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously mdio relied on GNU `ld`'s well known secret formula finding the beginning and end of sections. Compiling with LTO and optimizations seems to break that. Now there is a linker script that explains to the linker what is happening. `externally_visible` was also added to make sure the cmd functions do not get optimized away since they are not directly referenced from `main` (might be unnecessary).
|
https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-used-function-attribute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously mdio relied on GNU
ld's well known secret formula finding the beginning and end of sections. Compiling with LTO and optimizations seems to break that.Now there is a linker script that explains to the linker what is happening.
usedwas also added to make sure the cmd functions do not get optimized away since they are not directly referenced frommain(might be unnecessary).Addresses #37
Testing locally seems like everything still works as expected. Let me know if it needs any changes.