Fix translation of date type in schemaTranslator

wix · Dec 5, 2023 · 642a273 · 642a273
1 parent 9d769bc
commit 642a273
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/libs/external-db-bigquery/src/sql_schema_translator.spec.ts b/libs/external-db-bigquery/src/sql_schema_translator.spec.ts
@@ -158,7 +158,7 @@ describe('Sql Schema Column Translator', () => {
 
         describe('date time fields', () => {
 
-            test.each(['DATETIME', 'TIMESTAMP'])('%t', (t) => {
+            test.each(['DATETIME', 'TIMESTAMP'])('%s', (t) => {
                 expect( env.schemaTranslator.translateType(t) ).toEqual('datetime')
             })
 

diff --git a/libs/external-db-mysql/src/sql_schema_translator.spec.ts b/libs/external-db-mysql/src/sql_schema_translator.spec.ts
@@ -139,11 +139,18 @@ describe('Sql Schema Column Translator', () => {
         })
 
         describe('date time fields', () => {
-            test('date', () => {
-                ['DATE', 'DATETIME', 'TIMESTAMP', 'TIME', 'YEAR'].forEach(t => {
-                    expect( env.schemaTranslator.translateType(t) ).toEqual('datetime')
-                })
+            test.each([ 'DATETIME', 'TIMESTAMP' ])('%s', (t) => {
+                expect( env.schemaTranslator.translateType(t) ).toEqual('datetime')
+            })
+
+
+            test('time', () => {
+                expect( env.schemaTranslator.translateType('TIME') ).toEqual('time')
             })
+
+            test('date', () => {
+                expect( env.schemaTranslator.translateType('DATE') ).toEqual('date3')
+           })
         })
 
         describe('json fields', () => {