Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate uilib-native package #3304

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

ethanshar
Copy link
Collaborator

@ethanshar ethanshar commented Oct 9, 2024

Description

Decouple uilib-native (lib) components from uilib src components
This is in order to support mini-bundles and eventually code push
The fact that uilib-native's native part is in one package but the JS components is in anohter (react-native-ui-lib) was causing an issue
This PR separates the two without a breaking change to the community (they won't be required to install uilib-native package)

Changelog

Decouple uilib's native components from its JS library

Additional info

@ethanshar ethanshar marked this pull request as ready for review October 20, 2024 14:17
@ethanshar ethanshar added the Important for Next Release PR that must be included in the release version label Oct 22, 2024
@M-i-k-e-l
Copy link
Contributor

@ethanshar, this change does potentially break public users that use our native components, an error will appear only when such component is used (tested with the fix below*). This happens because they do not have the native-uilib package installed.
Moreover, in our project the Android build is failing: java.lang.StackOverflowError (no error message) not sure what's exactly is the issue there, however it works on master (I have a general issue with iOS ATM).

@M-i-k-e-l M-i-k-e-l assigned ethanshar and unassigned M-i-k-e-l Oct 22, 2024
@ethanshar
Copy link
Collaborator Author

@M-i-k-e-l
I merged your other PR #3319 and merge it to this PR
Both Android and iOS builds are working for me locally in this PR, can you double check?
I will try installing this version on a random project to see the issue you talked about

@ethanshar ethanshar assigned M-i-k-e-l and unassigned ethanshar Oct 28, 2024
@ethanshar ethanshar added Do Not Merge! and removed Important for Next Release PR that must be included in the release version Do Not Merge! labels Oct 28, 2024
@ethanshar
Copy link
Collaborator Author

@M-i-k-e-l
This is ready for review and verified by Niryo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants