Chore/lighten wit oracle base #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tommytrg
reviewed
Oct 9, 2024
Tommytrg
reviewed
Oct 9, 2024
Comment on lines
601
to
602
| _aggregateReducer.encode(), | ||
| _tallyReducer.encode(), |
There was a problem hiding this comment.
Suggested change
| _aggregateReducer.encode(), | |
| _tallyReducer.encode(), | |
| _aggregateReducer.encode(), | |
| _tallyReducer.encode(), |
Tommytrg
reviewed
Oct 9, 2024
| /// @notice Witnet Radon Retrieval. Modal request templates produce Witnet-compliant data requests | ||
| /// @notice that apply the same data retrieval script to multiple data providers that are expected to | ||
| /// @notice produce exactly the same result. Moreover, data requests built out of a modal request templates | ||
| /// @notice apply a Mode reducing function at both the Aggregate and Tally stages everytime they get |
There was a problem hiding this comment.
Suggested change
| /// @notice apply a Mode reducing function at both the Aggregate and Tally stages everytime they get | |
| /// @notice apply a Mode reducing function at both the Aggregate and Tally stages every time they get |
Tommytrg
reviewed
Oct 9, 2024
| /// @notice apply a Mode reducing function at both the Aggregate and Tally stages everytime they get | ||
| /// @notice eventually solved on the Wit/Oracle blockchain. You can optionally specify a list of filters | ||
| /// @notice to be applied at the Tally resolution stage (i.e. witnessing nodes on the Wit/Oracle blockchain | ||
| /// @notice reporting results that get ultimately filtred out on the Tally stage would get slashed by losing collateral). |
There was a problem hiding this comment.
Suggested change
| /// @notice reporting results that get ultimately filtred out on the Tally stage would get slashed by losing collateral). | |
| /// @notice reporting results that get ultimately filtered out on the Tally stage would get slashed by losing collateral). |
Tommytrg
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.