Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(de): update german i18n-guides #10113

Open
wants to merge 1 commit into
base: 5.0.0-beta
Choose a base branch
from
Open

feat(de): update german i18n-guides #10113

wants to merge 1 commit into from

Conversation

trueberryless
Copy link
Contributor

Description (required)

  • add recipe translation to deutsch.md because Beispiel fits better in German

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Nov 28, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 28, 2024 •
edited
Loading

❌ Deploy Preview for astro-docs-2 failed. Why did it fail? →

Built without sensitive environment variables

Name Link
🔨 Latest commit 721555a
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67481b61fb51520008389196

@trueberryless
Copy link
Contributor Author

Please correct me if I'm wrong, but I think requesting to merge this with #9240 is better than merging with main because the file got moved. But maybe git wouldn't even have merge conflicts because the changes moving and adding dont intercept with each other... Let me know if I rather should create PR to main!

sarah11918
sarah11918 requested changes Nov 29, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not be creating any PRs right now! 😅 We are not merging any PRs to main, and only a few core maintainers are finishing up v5 for release next week.

I'm sorry, but we are not merging anything right now. So this will have to wait until v5 is released.

Blocking so this does not get accidentally merged.

@trueberryless
Copy link
Contributor Author

@sarah11918 Not even when I wanna merge i to 5.0.0-beta 🥺

Fun aside, 100% understandable, gonna wait till next week... 😂🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 requested changes

Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trueberryless @sarah11918