fix(upgrade): enhance version comparison by normalizing `targetVersio…

…n` (#12577)
withastro · Dec 2, 2024 · b139390 · b139390
1 parent fa07002
commit b139390
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/dirty-bees-repair.md b/.changeset/dirty-bees-repair.md
@@ -0,0 +1,5 @@
+---
+'@astrojs/upgrade': patch
+---
+
+Fixes an issue where `@astrojs/upgrade` announces integration updates for already up to date packages
diff --git a/packages/upgrade/src/actions/install.ts b/packages/upgrade/src/actions/install.ts
@@ -90,8 +90,8 @@ function filterPackages(ctx: Pick<Context, 'packages'>) {
 	const devDependencies: PackageInfo[] = [];
 	for (const packageInfo of ctx.packages) {
 		const { currentVersion, targetVersion, isDevDependency } = packageInfo;
-		// Remove prefix from `currentVersion` before comparing
-		if (currentVersion.replace(/^\D+/, '') === targetVersion) {
+		// Remove prefix from version before comparing
+		if (currentVersion.replace(/^\D+/, '') === targetVersion.replace(/^\D+/, '')) {
 			current.push(packageInfo);
 		} else {
 			const arr = isDevDependency ? devDependencies : dependencies;