fix: don't match all paths when returning empty array from getStaticP…

…aths (#12906)
withastro · Jan 6, 2025 · 2d89492 · 2d89492
1 parent 383c2ab
commit 2d89492
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 1 deletion.
diff --git a/.changeset/gorgeous-cameras-smile.md b/.changeset/gorgeous-cameras-smile.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fixes a bug that caused pages that return an empty array from getStaticPath to match every path
diff --git a/packages/astro/src/core/render/params-and-props.ts b/packages/astro/src/core/render/params-and-props.ts
@@ -47,7 +47,6 @@ export async function getProps(opts: GetParamsAndPropsOptions): Promise<Props> {
 		base,
 	});
 
-	if (!staticPaths.length) return {};
 	// The pathname used here comes from the server, which already encoded.
 	// Since we decided to not mess up with encoding anymore, we need to decode them back so the parameters can match
 	// the ones expected from the users

diff --git a/packages/astro/test/fixtures/routing-priority/src/pages/empty-paths/[...slug].astro b/packages/astro/test/fixtures/routing-priority/src/pages/empty-paths/[...slug].astro
@@ -0,0 +1,18 @@
+---
+export function getStaticPaths() {
+	return []
+}
+const { slug } = Astro.params
+---
+
+<html lang="en">
+	<head>
+		<meta charset="utf-8" />
+		<meta name="viewport" content="width=device-width" />
+		<title>{slug}</title>
+	</head>
+	<body>
+		<h1>empty-paths/[...slug].astro</h1>
+		<p>slug: {slug}</p>
+	</body>
+</html>
diff --git a/packages/astro/test/routing-priority.test.js b/packages/astro/test/routing-priority.test.js
@@ -107,6 +107,11 @@ const routes = [
 		url: '/empty-slug/undefined',
 		fourOhFour: true,
 	},
+	{
+		description: 'do not match /empty-paths/hello to empty-paths/[...slug].astro',
+		url: '/empty-paths/hello',
+		fourOhFour: true,
+	},
 	{
 		description: 'matches /api/catch/a.json to api/catch/[...slug].json.ts',
 		url: '/api/catch/a.json',