Add support for Avro Schema Registry #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ah-
reviewed
Dec 31, 2017
setup.py
Outdated
| @@ -12,8 +12,11 @@ | |||
| readme = readme_file.read() | |||
|
|
|||
| requirements = [ | |||
| 'javaproperties', | |||
|
|
|||
ah-
approved these changes
Dec 31, 2017
|
Cool, this looks nice! +1 for adding an example |
jhickson
reviewed
Jan 3, 2018
| from ._serializer import Serializer | ||
|
|
||
|
|
||
| class AvroHelper: |
There was a problem hiding this comment.
I think a better name would be AvroSerde as it's not so much a helper as the whole implementation.
Can I take it the reason to have both serialisation and deserialisation centralised here is because configuration is common?
There was a problem hiding this comment.
I've now seen there's a AvroSerde below. Perhaps AvroSerdeImpl instead of AvroHelper then.
| if schema: | ||
| self._schema = avro_loads(schema) | ||
|
|
||
| def serialize(self, topic, data): |
There was a problem hiding this comment.
Would it be better both here and in deserilize to have a guard that self._serializer != None? That way a meaningful error message could be emitted saying that configure should be called first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
This adds a basic Serde using the existing confluent-kafka-python package.
Currently this is only tested as an isolated serde with a mocked Schema Registry. I think it would be worth adding an example that uses this to get some integration testing and catch bugs early -- I've added #41 for this.