my proposed updates, part 2 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 7, 2016 18:32
"rails db:migrate" won't work.
… instead of "rails test" which won't work.
controller tests are not located in "test/functional".
This reverts commit ecbf25bad0a83550824e0bbc4f4c383b851ba57d. When using Rails 5.0, "rails test" will work! So, my changes were outdated.
This reverts commit 6213a8ba3b10de56a3cfe9c806eda2da22375c78. When using Rails 5.0, "rails db:migrate" will work! So, my changes were outdated.
… instead of "rake test". I see, I'm not the only one whose brain is "version 4.2" :).
… instead of "rake generate scaffold". While "rake test" and "rails test" both are possible, "rake generate scaffold …" is not a valid syntax IMHO.
There is no obvious reason for using "rake-stats" (instead of "rails-stats") as link-target, is it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't find subdir "functional" within "test", but "controllers". So, I think this is a typo. In addition, the usage of "rails" and "rake" (especially when to use which) is not trivial, is it?
Cheers,
Frank.
P.S.: Sorry for any inconvenience due to unnecessary micro-commits. It was because I used Rails 4 by accident and already had pushed them when I recognized that.