Fix Guest Users

[AIC-BV]

remove unique:users onRegister to fix User guest accounts
See: #28

[mjauvin]

You would need to add the rule conditionally like here under complex conditional validation:

https://wintercms.com/docs/services/validation#conditionally-adding-rules

[AIC-BV]

Ok I added sometimes

[mjauvin]

I had something more like this in mind:

$rules['email'] = 'required|between:6,255|email';

$validation->sometimes('email', 'required|between:6,255|email|unique', function($input) {
    return \Winter\User\Models\User::where('email', $input->email)->where('is_guest', 0)->first() !== null;
});

Not sure if there's a better way to achieve the same

[bennothommo]

I'm going to close this and implement the validation here as Rule objects. This implementation is essentially checking the uniqueness of the email twice (once for the "sometimes" callback, and another with the unique rule that it adds), and also doesn't cover when usernames are used instead of email addresses for logins.

Thanks for the submission though, @AIC-BV.

[AIC-BV]

@bennothommo
Does this mean it won't be implemented?
It is required to make the user plugin work with guest accounts, so it's an important fix, even though its not optimal

[bennothommo]

I am working on an alternate PR that uses a Rule object instead, so it will be fixed.

[AIC-BV]

Is there any news on this? 😄

[LukeTowers]

@bennothommo ping 😉

[bennothommo]

Thanks for the reminder.

I did have a crack at this months ago, I think I got stopped by the fact we don't support DataAwareRules in Storm (https://laravel.com/docs/9.x/validation#using-rule-objects) yet. I need to include support for that in order to make the new rules work (albeit this would mean people would also need to update Winter and this plugin in order to support guests)