Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix saving sitemap definitions #19

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Fix saving sitemap definitions #19

merged 2 commits into from
Oct 9, 2024

Conversation

mjauvin
Copy link
Member

@mjauvin mjauvin commented Oct 8, 2024 •
edited
Loading

@mjauvin mjauvin self-assigned this Oct 8, 2024
@zoomyboy zoomyboy mentioned this pull request Oct 8, 2024
Closed
bennothommo
bennothommo approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@bennothommo bennothommo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, @mjauvin! Good to go if tested.

@mjauvin
Copy link
Member Author

mjauvin commented Oct 9, 2024

Yes, it has been tested.

@LukeTowers LukeTowers merged commit fd6c2e3 into main Oct 9, 2024
@LukeTowers LukeTowers changed the title Use standard method to get postdata form field name Fix saving sitemap definitions Oct 9, 2024
@LukeTowers LukeTowers deleted the fix-postdata branch October 9, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennothommo bennothommo bennothommo approved these changes

@LukeTowers LukeTowers Awaiting requested review from LukeTowers

Assignees

@mjauvin mjauvin

Labels
Status: Completed Type: Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Success message says - Definition updated but file is not generated?
3 participants
@mjauvin @bennothommo @LukeTowers