make sure we always get an array

wintercms · Dec 20, 2024 · bf78198 · bf78198
1 parent d7d1993
commit bf78198
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/modules/backend/formwidgets/TagList.php b/modules/backend/formwidgets/TagList.php
@@ -110,15 +110,17 @@ public function prepareVars()
      */
     public function getSaveValue($value)
     {
-        if (is_array($value)) {
-            $value = array_filter($value);
+        if (!is_array($value)) {
+            $value = [$value];
         }
 
+        $value = array_filter($value);
+
         if ($this->mode === static::MODE_RELATION) {
             return $this->hydrateRelationSaveValue($value);
         }
 
-        if (is_array($value) && $this->mode === static::MODE_STRING) {
+        if ($this->mode === static::MODE_STRING) {
             return implode($this->getSeparatorCharacter(), $value);
         }
 
@@ -129,12 +131,8 @@ public function getSaveValue($value)
      * Returns an array suitable for saving against a relation (array of keys).
      * This method also creates non-existent tags.
      */
-    protected function hydrateRelationSaveValue($names): ?array
+    protected function hydrateRelationSaveValue(array $names): ?array
     {
-        if (!is_array($names)) {
-            $names = [$names];
-        }
-
         $relation = $this->getRelationObject();
         $relationModel = $this->getRelationModel();
 

diff --git a/modules/backend/formwidgets/taglist/partials/_taglist.php b/modules/backend/formwidgets/taglist/partials/_taglist.php
@@ -29,7 +29,7 @@
     <?php else: ?>
         <input
             type="hidden"
-            name="<?= $field->getName() ?>"
+            name="<?= $field->getName() ?>[]"
             value="<?= $field->value ?>">
     <?php endif ?>
 <?php else: ?>